server
server copied to clipboard
Enhance IngestWebsiteResultHandler to handle exceptions properly
trafficstars
Background
As noted in PR #5001, the current implementation of IngestWebsiteResultHandler needs enhancement.
Tasks
- Make the
IngestWebsiteResultHandlersimilar to the ingest body of knowledge handler - Add a separate type in the base Python VC (Virtual Contributor) library
- Wire this new type to the handler
Current Limitations
Currently, if an exception occurs in the ingest website service, NO response will be received by the server, making it impossible to detect and handle failures properly. The current implementation assumes that if the handler is reached, the result is a success.
Related Code
// from src/services/infrastructure/event-bus/handlers/ingest.website.result.handler.ts
// this handler should be similar to the ingest body of knowledge one
// in order to do that I need to add a separate type in the base Python VC library and wire it here
// no time for that right now but will track it and do it rather soon
//
// for now if an exception occurs in the ingest website service NO response will be received by the server
// hence we can conclude that if we are here the result is a success
References
- PR: #5001
- Comment: Discussion #5001