miniredis icon indicating copy to clipboard operation
miniredis copied to clipboard

Extend `XPENDING` and add support for `XGROUP {CREATECONSUMER,DESTROY,DELCONSUMER}`, `XINFO {CONSUMERS,GROUPS}`, `XCLAIM`

Open sandyharvie opened this issue 3 years ago • 1 comments

As stated in the title, this PR adds support for the following commands:

  • XGROUP {CREATECONSUMER,DESTROY,DELCONSUMER}
  • XINFO {CONSUMERS,GROUPS}
  • XCLAIM

In addition, I've added support for IDLE to the XPENDING implementation.

sandyharvie avatar Aug 01 '22 19:08 sandyharvie

Hi! Thanks for the PR. It looks good on first glance, but I'll need some time to have a proper look.

alicebob avatar Aug 02 '22 07:08 alicebob

PR looks good. I'm still trying to fix the problem with pre 1.17 Go, but I might also say the minimum version of miniredis will be 1.17 (which seems reasonable to me since it's the last version pre-generics).

alicebob avatar Aug 09 '22 08:08 alicebob

PR looks good. I'm still trying to fix the problem with pre 1.17 Go, but I might also say the minimum version of miniredis will be 1.17 (which seems reasonable to me since it's the last version pre-generics).

I think I've fixed the remaining issues in https://github.com/alicebob/miniredis/pull/281/commits/65aebb7f823482339cf846fa7bcc798f44f27e85, but feel free to revert the changes if you choose to make 1.17 the minimum supported version.

sandyharvie avatar Aug 09 '22 13:08 sandyharvie

Now CI is happy, thanks. Can you squash all the commits? I'll have a final look then (it's a big pr :)

alicebob avatar Aug 09 '22 14:08 alicebob

thanks!

alicebob avatar Aug 10 '22 15:08 alicebob