GraphScope icon indicating copy to clipboard operation
GraphScope copied to clipboard

[BUG] Schema Fetch Failure in Compiler Due to Certain DDL Operations in Groot

Open BingqingLyu opened this issue 11 months ago • 2 comments

Describe the bug

As titled. This issue is triggered by specific data types, such as float, used in the DDL operations.

e.g., when creating new vertex or edge types with properties of datatype float, the compiler output error logs as follows:

 2024-12-25 16:53:50.529597049 INFO  (/workspaces/GraphScope/interactive_engine/executor/store/groot/src/db/graph/store.rs:252) [unnamed] create_vertex_type
 2024-12-25 16:53:50.530113222 INFO  (src/store/graph.rs:272) [unnamed] create_vertex_type
 2024-12-25 16:53:50.530196446 INFO  (/workspaces/GraphScope/interactive_engine/executor/store/groot/src/db/graph/store.rs:252) [unnamed] create_vertex_type
 2024-12-25 16:53:50.530683452 INFO  (src/store/graph.rs:312) [unnamed] create_edge_type
 2024-12-25 16:53:50.530758669 INFO  (/workspaces/GraphScope/interactive_engine/executor/store/groot/src/db/graph/store.rs:302) [unnamed] create_edge_type
 2024-12-25 16:53:50.531125119 INFO  (src/store/graph.rs:345) [unnamed] add_edge_kind
 2024-12-25 16:53:50.531184368 INFO  (/workspaces/GraphScope/interactive_engine/executor/store/groot/src/db/graph/store.rs:350) [unnamed] add_edge_kind
 2024-12-25 16:53:50.531509611 INFO  (src/store/graph.rs:312) [unnamed] create_edge_type
 2024-12-25 16:53:50.531584404 INFO  (/workspaces/GraphScope/interactive_engine/executor/store/groot/src/db/graph/store.rs:302) [unnamed] create_edge_type
 2024-12-25 16:53:50.531985117 INFO  (src/store/graph.rs:345) [unnamed] add_edge_kind
 2024-12-25 16:53:50.532062001 INFO  (/workspaces/GraphScope/interactive_engine/executor/store/groot/src/db/graph/store.rs:350) [unnamed] add_edge_kind
 [2024-12-25 16:53:51,806][INFO][grpc-worker--2][c.a.g.g.f.SnapshotCache] schema updated. schema version [95]
 [2024-12-25 16:53:51,807][INFO][grpc-worker--2][c.a.g.g.f.SnapshotCache] notify listener for snapshot id [2647]
 [2024-12-25 16:53:52,227][WARN][pool-17-thread-1][c.a.g.c.i.m.f.DynamicIrMetaFetcher] failed to read meta data, error is {}
 java.lang.NullPointerException: null
        at com.alibaba.graphscope.common.ir.meta.schema.SchemaSpecManager.convert(SchemaSpecManager.java:107)
        at com.alibaba.graphscope.common.ir.meta.schema.SchemaSpecManager.<init>(SchemaSpecManager.java:41)
        at com.alibaba.graphscope.common.ir.meta.schema.IrGraphSchema.<init>(IrGraphSchema.java:50)
        at com.alibaba.graphscope.groot.servers.ir.GrootIrMetaReader.readMeta(GrootIrMetaReader.java:46)
        at com.alibaba.graphscope.common.ir.meta.fetcher.DynamicIrMetaFetcher.syncMeta(DynamicIrMetaFetcher.java:81)
        at com.alibaba.graphscope.common.ir.meta.fetcher.DynamicIrMetaFetcher.lambda$new$0(DynamicIrMetaFetcher.java:59)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
        at java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305)
        at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at java.base/java.lang.Thread.run(Thread.java:829)
[20

BingqingLyu avatar Dec 25 '24 11:12 BingqingLyu

The reason is that, in https://github.com/alibaba/GraphScope/blob/main/interactive_engine/common/src/main/java/com/alibaba/graphscope/groot/common/util/IrSchemaParser.java#L126 we didn't convert DataType like Float. This is related to the data type refactor issue #4362 .

BingqingLyu avatar Dec 25 '24 12:12 BingqingLyu

/cc @BingqingLyu, this issus/pr has had no activity for for a long time, could you folks help to review the status ? To suppress further notifications,

  • for issues,
    • if it is waiting for further response from the reporter/author, please help to add the label requires-further-info,
    • if you have already started working on it, please add the label work-in-progress to the issue,
    • if this issue requires further designing discussion and not in current plan, or won't be fixed, please add the label requires-further-discussion or wontfix to the issue,
  • for pull requests,
    • if you are still working on it and it is not ready for reviewing, please convert this pull request as draft PR,
    • if you have decided to hold this development on, please add the requires-further-discussion label to the pull request. Thanks!

github-actions[bot] avatar Jan 12 '25 00:01 github-actions[bot]