GraphScope
GraphScope copied to clipboard
feat(ci): refine maven log with --no-transfer-progress option
What do these changes do?
- only run ci automatically when repository is alibaba/GraphScope
- don't run ci if PR is draft or with
WIPtitile
Related issue number
close #4172
This PR is under assistance of Tongyi Lingma(本次 PR 借助通义灵码辅助完成)
Hey there and thank you for opening this pull request! 👋🏼
We require pull request titles to follow the Conventional Commits specification
and it looks like your proposed title needs to be adjusted.
Details:
Unknown scope "ci" found in pull request title "feat(ci): refine maven log with --no-transfer-progress option". Scope must match one of: core, python, k8s, coordinator, one, interactive, insight, analytical, learning, flex.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 22.33%. Comparing base (
4eadc2e) to head (9ac3fee). Report is 24 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #4174 +/- ##
===========================================
- Coverage 46.45% 22.33% -24.12%
===========================================
Files 173 203 +30
Lines 16171 18401 +2230
===========================================
- Hits 7512 4110 -3402
- Misses 8659 14291 +5632
see 103 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update c7b3f35...9ac3fee. Read the comment docs.
Hi @Thespica Thanks for your commit!
However, I don't very agree with these modifications:
- for
alibaba/graphscope, the CI runs on forks is fine. It does not count to this repo quota; - for WIP, Github Draft function is turned on for this repo...
If for CI refinement, I suggest one thing is doable:
I also agree that --no-transfer-progress is much better than -q for maven build. :)
Hi @Thespica Thanks for your commit!
However, I don't very agree with these modifications:
- for
alibaba/graphscope, the CI runs on forks is fine. It does not count to this repo quota;- for WIP, Github Draft function is turned on for this repo...
If for CI refinement, I suggest one thing is doable: I also agree that
--no-transfer-progressis much better than-qfor maven build. :)
Thanks for your comment @yecol
So the target is that:
- Repo constraint: remain origin, partly run for forked repository;
- WIP PR: let WIP PR run CI;
- Maven log: replace
-qby--no-transfer-progressto offer more info.
Right?
Hi @Thespica, I mean:
- ~~Repo constraint: remain origin, partly run for forked repository;~~ (Maybe no change needed;)
- ~~WIP PR: let WIP PR run CI;~~ (Maybe no change needed;)
- Maven log: replace -q by --no-transfer-progress to offer more info. (Yes!)
And other contributions or suggestions, (especially to improve user-friendliness and to get hands on) are warmly welcome!
Hello @yecol
I consider the replacement of -q option has been done. But I am not sure about why CI failed. Please take a look and give me some suggestions, thank you!
/cc @yecol @sighingnow, this issus/pr has had no activity for a long time, please help to review the status and assign people to work on it.