GraphScope icon indicating copy to clipboard operation
GraphScope copied to clipboard

The `GraphBuilder` test cases can be categorized into two test groups of Algebra and Expression

Open longbinlai opened this issue 1 year ago • 1 comments

Now in interactive_engine/compiler/src/test/java/com/alibaba/graphscope/gremlin/antlr4x/GraphBuilderTest.java, there are two kinds of test cases.

The Algebra case: For example, RelNode node = eval("g.V().has('name', containing('mar'))"), as introduced by the eval() function.

The Expression case: For example, RexNode expr = rexBuilder.makeIn( builder.source(new SourceConfig(GraphOpt.Source.VERTEX)) .variable(null, GraphProperty.ID_KEY), ImmutableList.of(builder.literal(0), builder.literal(72057594037927937L))); , as introduced by RexBuilder directly.

We can separate these two kinds of test cases into two individual tests.

longbinlai avatar Mar 04 '24 07:03 longbinlai

/cc @shirly121, this issus/pr has had no activity for for a long time, could you folks help to review the status ? To suppress further notifications,

  • for issues,
    • if it is waiting for further response from the reporter/author, please help to add the label requires-further-info,
    • if you have already started working on it, please add the label work-in-progress to the issue,
    • if this issue requires further designing discussion and not in current plan, or won't be fixed, please add the label requires-further-discussion or wontfix to the issue,
  • for pull requests,
    • if you are still working on it and it is not ready for reviewing, please convert this pull request as draft PR,
    • if you have decided to hold this development on, please add the requires-further-discussion label to the pull request. Thanks!

github-actions[bot] avatar Mar 12 '24 00:03 github-actions[bot]