GraphScope icon indicating copy to clipboard operation
GraphScope copied to clipboard

feat(interactive): Support implicit type conversion for vertex index scan

Open zhanglei1949 opened this issue 1 year ago • 0 comments

For Interactive compute engine, we need to provide the ability for implicit type conversion in predicate. (The only scenario where the type conversion may happen).

For most of the predicates, we convert it to a c++ expression, and the implicit conversion if down by C++ compiler. For example.

MATCH(p : Person) where p.creditCardId = 1234 return p;

will be convert into an expression

bool predicate(int64_t creditCardId, int32_t target_value) {
    return creditCardId == target_value; // compare between a int64_t and int32_t.
}

However, when the query perform index scan for the vertex, we use indices for faster scan.

MATCH(p: Person { id : 1234}) return p;

will be compiled to

auto vertexSet = graph.ScanVertexFromOid(person_label_id, Any::From(1234));

Which will cause runtime error.

So, In this PR, we enable id_indexer support implicit type conversion between currently supported primary keys:

  • uint32_t
  • uint64_t
  • int32_t
  • uint32_t

Note that conversion between String and other type are not supported, since compiler will throw the error before compiling to a physical plan.

zhanglei1949 avatar Dec 12 '23 04:12 zhanglei1949