1D Convolutions: Hardcoded code strings

[stormofice]

Bug Report

Description

A few code strings in this chapter are not backed by the implementation dependent code under code/. Changing these to rely on the language specific implementation will improve consistency with the other code (for example if length() is not a function in another language).

Screenshots

The aforementioned strings have been marked up here:

For Algorithm Archive Developers

• [ ] The bug can be reproduced
• [ ] The bug can be fixed (if not, please explain why not in a comment below)
• [ ] There is a timeline to fix the bug
• [ ] The bug has been fixed (Please link the PR)

[leios]

I don't really know how to solve this issue. We could have a language method at the start of the file that allows us to create html variables or something that we then slot in to the text?

So like

{% method %}
{% sample lang="jl" %}
    set variables to i, j, k
{% common %}
    Set variables to some other name
{% endmethod %}

Sorry it's hand-wavey. Still thinking about it!

[jiegillet]

Honestly, I would probably change the text to say something like:

Finally, as we mentioned before, it is possible to center bounded convolutions by changing the location where we calculate the each point along the filter. This can be done by offsetting the filter signal

Because depending on the language, that line you reference may look vastly different. I'm working on a Haskell version and it's not there at all.

[leios]

To be honest, it said that originally, then I changed it due to feedback. I am happy to change it back