algorithm-archive icon indicating copy to clipboard operation
algorithm-archive copied to clipboard

Convolutions in 1d in rust

Open eengamer2007 opened this issue 3 years ago • 4 comments

implemented the convolutions 1d in rust

eengamer2007 avatar Nov 19 '22 21:11 eengamer2007

i saw somewhere that I should add my name to the contributers list since this is my first contribution. Should that be in this pull request?

eengamer2007 avatar Nov 22 '22 14:11 eengamer2007

Yeah, add that to this pr, if you can

leios avatar Nov 22 '22 15:11 leios

Oof, sorry for the delay in the response.

So, the main problem with your PR currently is that the line numbers don't track correctly. I don't see a reason to refuse your code in the AAA now, so please make sure the lines you include your code at are indeed the correct ones before I merge them.

Amaras avatar Jan 13 '23 23:01 Amaras

sorry for the late fix, school was keeping me busy.

eengamer2007 avatar Feb 06 '23 11:02 eengamer2007