js-algorand-sdk

js-algorand-sdk copied to clipboard

ATC: addMethodCall, addTransaction returns this

1

This simply changes the return type of `addTransaction` and `addMethodCall` from `void` to `AtomicTransactionCompose` so these methods return the ATC. The goal is to allow chaining of methods when using...

joe-p

Expose ATC transactions field with a getter method

5

## Problem Right now the ATC holds an array of TransactionWithSigner objects that is private https://github.com/algorand/js-algorand-sdk/blob/develop/src/composer.ts#L120 This means to get access to the transactions, the developer must call `buildGroup` which...

barnjamin

## Problem There's been at least a few cases of folks facing more friction than is desirable to get browser tests running locally. The story asks to either (or both):...

michaeldiamant

## Problem Discussion in https://github.com/algorand/js-algorand-sdk/pull/675#issuecomment-1295392849, motivated a review of type checking configuration options: https://www.typescriptlang.org/tsconfig#Type_Checking_6248. As a hopefully lightweight way to improve safety, the story requests assessing + configuring stricter type...

michaeldiamant

## Problem `npm run lint` shows the configured _typescript-eslint_ version does _not_ support the project's TypeScript version. Here's an example taken from https://app.circleci.com/pipelines/github/algorand/js-algorand-sdk/690/workflows/b2db26b7-95e5-4b02-b9ce-6e0b3b5ab96e/jobs/4006: ``` WARNING: You are currently running a...

michaeldiamant

## Problem https://github.com/algorand/js-algorand-sdk/pull/684 corrects a `package-lock.json` discrepancy introduced in https://github.com/algorand/js-algorand-sdk/pull/680. The problem wasn't identified until a release was partially completed. The story requests modifying CI so that a similar problem...

michaeldiamant

### signTransaction should refuse to sign any txn with lease not exactly 32 bytes Currently if you manually set a `.lease` field on a transaction that is not 32 bytes,...

d13co

Remove dependency on js-sha256

2

## Problem The old package js-sha256 uses require() and thus causes problems running in a browser context. See issue [https://github.com/emn178/js-sha256/issues/33](https://github.com/emn178/js-sha256/issues/33) on the repo suggesting that it be deprecated. ## Solution...

SilentRhetoric

Incorrect msgpack decoding on global state delta values

1

### Subject of the issue When requesting a Block from algod and decoding each transaction, the global state deltas of the `apply_delta.eval_delta` contain incorrect data. using ```ts const block =...

barnjamin

Insecure dependencies are used: Switch to newer, audited dependencies

3

- js-sha256, js-sha3, js-sha512 - can be replaced with [noble-hashes](https://github.com/paulmillr/noble-hashes), which were audited and developed with a grant from Ethereum Foundation - tweetnacl - can be replaced with [noble-curves](https://github.com/paulmillr/noble-curves) which...

paulmillr