go-algorand-sdk icon indicating copy to clipboard operation
go-algorand-sdk copied to clipboard

Published 20 hours ago • verified publisher icon algorand

feat: add min-balance to account information model

Open kieranroneill opened this issue 1 year ago • 1 comments

Summary

Simply exposes the min-balance in the Account model as defined in the REST API response.

As the API defines the min-balance as required, there should always be a value. As of now (19th January 2024), minimum balance should always be >= 100,000 microAlgos.

Closes #272.

kieranroneill avatar Jan 19 '24 20:01 kieranroneill

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 19 '24 20:01 CLAassistant

@kieranroneill thanks for contributing, can you try rebasing this to give it another go?

gmalouf avatar May 15 '24 18:05 gmalouf

@kieranroneill thanks for contributing, can you try rebasing this to give it another go?

Hey @gmalouf I have updated the PR with the latest version :)

kieranroneill avatar May 16 '24 07:05 kieranroneill

I jusr realized that the Account struct is actually generated based on the specification file in indexer using the sdk codegen action that runs on this repository.

There is a draft PR open to add this: https://github.com/algorand/indexer/pull/1596, I'm looking into what tests need to go in before moving forward.

gmalouf avatar May 16 '24 16:05 gmalouf

#641 was just merged that addresses this (now that https://github.com/algorand/indexer/pull/1596) was merged

gmalouf avatar May 23 '24 16:05 gmalouf