conduit icon indicating copy to clipboard operation
conduit copied to clipboard

Add credentials for telemetry

Open algochoi opened this issue 2 years ago • 2 comments

Summary

Adds telemetry credentials for our Opensearch dev cluster.

Test Plan

Push telemetry events on startup on local conduit instance.

algochoi avatar Aug 23 '23 20:08 algochoi

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.82%. Comparing base (442791a) to head (60a010c). Report is 78 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   67.66%   71.82%   +4.16%     
==========================================
  Files          32       37       +5     
  Lines        1976     2747     +771     
==========================================
+ Hits         1337     1973     +636     
- Misses        570      675     +105     
- Partials       69       99      +30     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

codecov[bot] avatar Aug 23 '23 20:08 codecov[bot]

Could you move the defaults into the code? That way they can be updated with a software update rather than going stale if we want to change them in the future.

@winder That makes sense since we will likely change the URI some time in the future. But moving the defaults in the code could make it harder for users to set their custom telemetry endpoints (changing source code and recompiling the binary seems a bit more cumbersome). Is this an okay tradeoff here?

algochoi avatar Sep 05 '23 13:09 algochoi