api-clients-automation
api-clients-automation copied to clipboard
algolia
fix(specs): update analytics and abtesting max pagination query limit
🧭 What and Why
Analytics team is enforcing the limit where combination of limit and offset can only target the top 1000 rows.
Documentation updated to reflect those updates
🎟 JIRA Ticket: OPTIM-1255
Changes included:
Limit and Offset were previously defined in a global common folder. Usages were made in analytics and one single usage in AB test.
To avoid any confusion
- move usage with improved specificity about limit and offset into analytics
- define single usage in AB test API locally
- remove no-longer definition from common folder
🧪 Test
✔️ Code generated!
| Name | Link |
|---|---|
| 🪓 Triggered by | 1e60bbbbe39e112cc33856010e94f70ba3ebac8a |
| 🍃 Generated commit | da0d6bd392cfd5e9486393aebb3cfdfeea90a6a8 |
| 🌲 Generated branch | generated/docs/analytics/update_max_pagination_query_limit |
📊 Benchmark results
Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
| Language | Req/s |
|---|---|
| javascript | 1670 |
| go | 1551 |
| php | 1460 |
| csharp | 1382 |
| java | 1109 |
| python | 1013 |
| ruby | 865 |
| swift | 755 |
should we wait for someone from your team to review as well, or is it good to go?
@shortcuts we need to wait - we had to revert the change and i'll approve when we get it redeployed
Thanks for the review @shortcuts . As @cdhawke said, this change has been reverted and therefore I put the PR in draft