algoliasearch-client-ruby icon indicating copy to clipboard operation
algoliasearch-client-ruby copied to clipboard

chore: update faraday dependency range

Open daedric opened this issue 3 years ago • 2 comments

Q A
Bug fix? no
New feature? no
BC breaks? no
Need Doc update no

Describe your change

Update Faraday dependency.

What problem is this fixing?

Strong dependency on "old" Faraday major.

daedric avatar Feb 16 '22 13:02 daedric

I was not able to run the integration tests however in some private code I was able to use Faraday 2.2 without any issue :)

daedric avatar Feb 16 '22 16:02 daedric

@DevinCodes any news on this one?

sfate avatar Jun 19 '22 10:06 sfate

@DevinCodes @daedric any help needed here to get this merged? I'm unfortunately blocked from using algoliasearch-rails until this is resolved - happy to contribute!

aaronstillwell avatar Aug 27 '22 14:08 aaronstillwell

Done, I'm sorry I missed the (old) notification :)

daedric avatar Aug 29 '22 09:08 daedric

Quick update; this change seems to require us to drop support for some older Ruby versions, so we're internally discussing how we can address this properly. Will keep you posted!

DevinCodes avatar Sep 09 '22 09:09 DevinCodes

👀

this ruby gem prevents the gem google-cloud-pubsub from resolving due to their ~> 2.0 on faraday. Any update?

courtsimas avatar Sep 16 '22 21:09 courtsimas

While we wait for the team to get back to us on their decision moving forward, we can work against @daedric's fork with:

gem 'algolia', git: 'https://github.com/daedric/algoliasearch-client-ruby', ref: '911b338'

aaronstillwell avatar Sep 16 '22 21:09 aaronstillwell

Quick update; this change seems to require us to drop support for some older Ruby versions, so we're internally discussing how we can address this properly. Will keep you posted!

I would really move forward and stop supporting ruby versions that are well behind EOL, 2.6 is now out of support so even maintaining 2.5 would be generous. As for faraday, which you rely upon, they don't support ruby versions after their EOL and even the support for 0.x was stopped as only the 1.x and 2.x received releases lately.

I don't understand why algolia is so desperately lagging in version updates as this general approach of "leave no one behind" will not foster a more general consensus for developers to keep upgrading their dependencies and by that keeping their applications unsafe as even security fixes aren't applied bc of "version constraints"

bvogel avatar Sep 20 '22 18:09 bvogel

Sorry for the delay in coming back to you. We're indeed going to drop support for the older Ruby versions. We're not going to release today given that it's a Friday, but I'm working on this first thing Monday morning (Paris time). I'll drop a note here when a release is made!

DevinCodes avatar Sep 23 '22 09:09 DevinCodes