algoliasearch-client-javascript icon indicating copy to clipboard operation
algoliasearch-client-javascript copied to clipboard

algoliasearch-client-javascript provide cjs, es, but does not support deduping

Open kopax-polyconseil opened this issue 3 years ago • 1 comments

Hello,

We had a memory leak while building our application, and we were able to solve it by increasing the memory for node, but while investigating, we noticed this anomaly:

image

It seems the UMD module gets builded with webpack, while I can see that you are distributing ES and CJS format.

In your documentation here it is written:

Both versions come as UMD and ESM modules.

Inspecting at your package.json, it seems you are not defining the module, is it possible to release a version that fix the module as we rather not ship all of algoliasearch to our web clients.

Thanks in advance !

related issues

  • https://github.com/bvaughn/react-error-boundary/issues/114

fix

We manage to fix it with webpack resolve.alias

kopax-polyconseil avatar Jul 27 '22 10:07 kopax-polyconseil

This screenshots illustrate the potential gain of using CJS :

  • With UMD : Capture d’écran 2022-07-27 à 15 22 58
  • With CJS : Capture d’écran 2022-07-27 à 15 18 58

I used Webpack Bundle Analyzer to do this analyze.

cedricls1 avatar Jul 27 '22 13:07 cedricls1