algoliasearch-client-javascript icon indicating copy to clipboard operation
algoliasearch-client-javascript copied to clipboard

Null value for GetABTestResponse.ts

Open SophieManley03 opened this issue 5 years ago • 4 comments

Hey team,

I noticed that in GetABTestResponse.ts the type of clickSignificance and conversionSignificance can't be null. But it can happen. For example when you just have created a test.

SophieManley03 avatar Oct 14 '20 11:10 SophieManley03

is it explicitly set to null or is the key not given?

Haroenv avatar Oct 14 '20 13:10 Haroenv

if so, it looks like the doc is wrong too: https://www.algolia.com/doc/api-reference/api-methods/get-ab-test/#response

Haroenv avatar Oct 14 '20 13:10 Haroenv

it's explicitly set to null. I am reaching out to the team. Thanks for your answer :)

SophieManley03 avatar Oct 14 '20 13:10 SophieManley03

We're gonna update the documentation :)

SophieManley03 avatar Oct 14 '20 13:10 SophieManley03