nativescript-oauth icon indicating copy to clipboard operation
nativescript-oauth copied to clipboard

Support multiple instances

Open chilltemp opened this issue 8 years ago • 1 comments
trafficstars

Right now index.ts has a bunch of functions/variables that are static. This prevents us from having multiple instances of oauth at once. My problem is that it makes unit testing harder, but what if someone was coding to multiple auth providers? (I know it would be better for a single provider with federation to others. This is just a what-if.)

chilltemp avatar Sep 22 '17 18:09 chilltemp

Definitely. This is something I’ve been wanting to do for a little while now, but haven’t had a chance yet.

On Sep 22, 2017, at 2:31 PM, chilltemp [email protected] wrote:

Right now index.ts has a bunch of functions/variables that are static. This prevents us from having multiple instances of oauth at once. My problem is that it makes unit testing harder, but what if someone was coding to multiple auth providers? (I know it would be better for a single provider with federation to others. This is just a what-if.)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/alexziskind1/nativescript-oauth/issues/55, or mute the thread https://github.com/notifications/unsubscribe-auth/ABkAswAP7MfRHyV__3NTOYTs5o-Yvlq-ks5sk_zugaJpZM4PhE5M .

alexziskind1 avatar Sep 22 '17 18:09 alexziskind1