"Clear Selected" and "Clear Completed" both delete the files.

[tylerdurden4285]

Using DELETE_FILE_ON_TRASHCAN=true works to remove the files selected just fine, however since only "clear selected" has the trashcan icon then it should only work for that selection. It currently works ALSO for "Clear completed". This option of "Clear completed" should be only to simply remove the completed from the gui, but keep the files in tact on the storage. There is no reason that it should delete for both options. This means I need to either:

a. manually delete files myself

b. turn it off so that I can clean without deleting files (as I should be able to do regardless of true/false value for this environment variable)

c. Touch neither options and have a massive list of previously completed files show (currently what I do but problematic)

I am completely open to the fact that this is likely user error and I am missing something with environment variables, but if not then this is a serious bug for a basic core feature of the app that would need looking into since it's not behaving as expected.

Additionally I'd like to say that "Clear Selected" and "Clear Completed" are really similar sounding and might be way more clear if you just made it "Delete Files" "Clear Completed" or something along those lines (keeping the icons as is)

[FMauroy]

I just deleted tens of files that took me hours to download by clicking "Clear completed", thinking it would simply clear the queue, like most similar programs do. Why no confirmation popup? Or at least a warning below? Is there a way to undelete those files?

[FMauroy]

I dug a bit further and discovered that the "DELETE_FILE_ON_TRASHCAN" setting was set to "true" in the "docker-compose.yml" file when running on Umbrel. A warning below the list of buttons when this setting is on could be a nice feature to implement...

[tylerdurden4285]

Was this resolved or accidentally closed?

[alexta69]

It was closed as "Completed" instead of "Not planned" accidentally. I disagree that "Clear selected" and "Clear completed" should behave differently -- the action is "Clear", and if the user has set it so that the "Clear" action means deleting the file, then it should behave that way, consistently. As to a confirmation dialog, since the DELETE_FILE_ON_TRASHCAN option is not the default, but an explicit setting of the user, I don't see a reason to further encumber the user with dialogs -- the intent has been made clear by changing this option from its default, and that is enough in my opinion.