react-json-tree icon indicating copy to clipboard operation
react-json-tree copied to clipboard

Possible mistype

Open ziflex opened this issue 7 years ago • 0 comments
trafficstars

I have notice that valueRenderer receives a values twice as arg1 and arg2.

https://github.com/alexkuz/react-json-tree/blob/master/src/JSONValueNode.js#L22

Shouldn't nodeType be send as the 2nd arg?

<span {...styling('valueText', nodeType, keyPath)}>
  {valueRenderer(valueGetter(value), nodeType, ...keyPath)}
</span>

ziflex avatar Jan 16 '18 19:01 ziflex