Alex Gibson
Alex Gibson
+1 for this - having helpers inside macros, inside other macros feels like too many layers of abstraction to me. Agree `res_img()` should be enough in most cases.
@nathan-barrett some answers to some of your questions: > Is there anytime that we would use high_res_image over resp_image? Not really, `resp_img()` can do exactly the same thing as `high_res_img()`,...
I’ll leave it to both of you to figure out what’s best, but I’ll vote for code simplicity over adding more hidden complexity (whatever that ends up looking like) 👍
An extra 2 pence: my example would also work well with absolute paths for all macros, plus things like inline SVGs (which isn't used anywhere, at least yet). But it...
I took a look at the 1passwrod extension to see how they handle this, and whilst they also use a very high z-index value, they add some clever additional behaviour...
@stevejalim want to do the honours and close this one out? 🎉
@cbcleveland based on our last conversations, is there anything that needs doing here - or can this issue be closed out? thanks
We add new files a lot more than we remove them, so if removing unneeded files manually is less work than it would take to set up automation for it,...
These files should have been removed from bedrock first if they are no longer needed. Because they were removed from the [L10n repo](https://github.com/mozilla-l10n/www-l10n/pull/382) instead, the PR automation is now trying...
It might also be possible that some of the files removed in https://github.com/mozilla-l10n/www-l10n/pull/382 are actually still in use?