crio support

[faust64]

trafficstars

Hi,

Quick question, as I am testing this out on OpenShift, I'm reading the following logs out of pumba:

time="2019-02-22T07:44:04Z" level=warning msg="no containers to kill" app=pumba function="github.com/alexei-led/pumba/pkg/chaos/docker.(*KillCommand).Run" source="docker/kill.go:90"
time="2019-02-22T07:47:04Z" level=warning msg="no containers to kill" app=pumba function="github.com/alexei-led/pumba/pkg/chaos/docker.(*KillCommand).Run" source="docker/kill.go:90"
time="2019-02-22T07:50:04Z" level=warning msg="no containers to kill" app=pumba function="github.com/alexei-led/pumba/pkg/chaos/docker.(*KillCommand).Run" source="docker/kill.go:90"

This is a bit surprising, as I've started a few pods for pumba to play with:

testdevel    dummy1-6bf899945c-gt6sk       1/1       Running     0   23h       10.131.2.72     compute2.example.com   <none>
testdevel    dummy1-6bf899945c-hmzz6       1/1       Running     0   23h       10.130.0.186    master3.example.com    <none>
testdevel    dummy1-6bf899945c-kj86m       1/1       Running     0   23h       10.130.3.6      compute3.example.com   <none>
testdevel    dummy2-b6554f9b8-657lz        1/1       Running     0   23h       10.130.3.7      compute3.example.com   <none>
testdevel    dummy2-b6554f9b8-p965v        1/1       Running     0   15h       10.128.0.147    master2.example.com    <none>
testdevel    dummy2-b6554f9b8-xfrnj        1/1       Running     0   23h       10.130.0.187    master3.example.com    <none>

Did set my daemonsets' pod arguments to match those dummy pods based on a regexpr:

args: [ "--random", "--interval", "30s", "kill", "--signal", "SIGKILL", "re2:.*dummy.*" ]

Then, added a label to one of my nodes, hoping to see pumba killing my corresponding Pods:

NAME          READY     STATUS    RESTARTS   AGE       IP            NODE                                           NOMINATED NODE
pumba-wbdz9   1/1       Running   0          6m        10.131.2.82   compute2.example.com   <none>

Container name seems to be properly defined, from crio point of view:

e899a76f893b3       docker.io/library/busybox@sha256:4415a904b1aca178c2450fd54928ab362825e863c0ad5452fd020e92f7a6a47e                             24 hours ago        Running             dummy                   0

Any chance pumba wouldn't support crio?

Any plan to implement such a thing? Or any indications for my trying to submit a PR on that matter?

[alexei-led]

@faust64 never tried crio, sorry. Pumba is using Docker SDK, so probably some SDK method is not working for crio as for docker. I have no environment to test this. If you could test and submit a PR or a place to fix, it would be a great help.