gnome-github-notifications icon indicating copy to clipboard operation
gnome-github-notifications copied to clipboard

Notifications not working on Ubuntu

Open aarondill opened this issue 2 years ago • 3 comments

Ubuntu Version: Ubuntu 22.04.1 LTS Gnome Version: 42.5 When notifications are received, /var/log/syslog contains the following error: [GITHUB NOTIFICATIONS EXTENSION][ERROR] Cannot notify Error: Expected type string for argument 'property_name' but got type GObject_Object

Having done a little research, making the following change in extension.js fixes my issue and allows notifications to be sent.

- this._source.notify(notification);
+ this._source.showNotification(notification);

aarondill avatar Feb 01 '23 02:02 aarondill

To be clear, this is relating to desktop push notifications, IE the setting show notification alert

aarondill avatar Feb 01 '23 02:02 aarondill

It seems #50 is designed to solve exactly this issue

aarondill avatar Feb 01 '23 02:02 aarondill

#50 @alexduf will this be merged?

Aceix avatar Jul 12 '23 16:07 Aceix