redmine_knowledgebase icon indicating copy to clipboard operation
redmine_knowledgebase copied to clipboard

Quickfix, replaces thumbnail_url with polymorphic_url

Open wiesion opened this issue 4 years ago • 1 comments

As described in https://github.com/rails/rails/pull/15840 - *_path methods should not be allowed within Mailer actions.

The original code is in fact constructing an absolute URL, but is doing so by making using of a *_path method. This is fine for web and data views, but not for Mailer views.

Rails' polymorphic_url exists since Version 2 and its syntax experienced no changes, so i assume it should be a backward compatible replacement.

wiesion avatar Mar 13 '21 08:03 wiesion

This should also address the issues #383 and #388.

wiesion avatar Mar 13 '21 08:03 wiesion

thy not just use return thumbnail_url(thumb) that works fine for me?

lauer avatar May 04 '23 08:05 lauer

Closing this in favour of #406

alexbevi avatar May 04 '23 13:05 alexbevi