Alexander Weiß

Results 38 comments of Alexander Weiß
trafficstars

@fortmarek Thanks a lot for the hint, I have updated the code and for direct dependencies it seems to work. What I was wondering is about the two following points:...

> It's fine to recreate GraphTraverser on-demand and often, it does not hold any state by itself. Does this mean whenever we map a target you would go down the...

@fortmarek Sorry I was quite busy since the beginning of the year and didn't find the time to continue working on this. How do you want to proceed with this...

@fortmarek To continue, I would then follow the approach I have started here or do you see any issues with that ? I guess adding the warning to the linter...

> Yes! I'd add unit tests to the mapper, as well as an acceptance test with a fixture that mimics the scenario. Let us know when that is done and...

@fortmarek @pepicrft I was finally able to add the missing unit and acceptance tests. I do hope it fits the current style and I did not introduce some other unwanted...

@pepicrft I have implemented the changes you requested. I am not not entirely sure if they match your expectations. Therefore I would appreciate a feedback from your side 🙂

@pepicrft thanks a lot for the review and merge ! I was just wondering, should I create a follow up PR fixing this https://github.com/tuist/tuist/pull/5773#discussion_r1521804522 ?

Hey @stephencelis I am so sorry.. I totally forgot to reply to this issue and basically forgot it exists. I stopped working on that project that caused this error. If...

Hi @dianaafanador3, thanks a lot for this information. Is there some issue or PR which I can subscribe to, to keep track of that implementation or is it just internally...