aleph.js icon indicating copy to clipboard operation
aleph.js copied to clipboard

Code Coverage

Open shadowtime2000 opened this issue 4 years ago • 5 comments
trafficstars

In 1.8.0 LCOV got support with code coverage and denos testing thing so I think we should use a code coverage service so we can make sure everything is being tested. We could use coveralls.io or codecov, I prefer coveralls but I have never used codecov.

shadowtime2000 avatar Mar 03 '21 02:03 shadowtime2000

From what I've seen, Codecov is more modern, it has a cleaner interface and seems to be better integrated with Github but Coveralls is older so maybe they have better support 🤷. But in my opinion, as Codecov seems more modern, it will surely have support for Deno sooner.

Hunam6 avatar Mar 03 '21 17:03 Hunam6

Yeah, I have only used coveralls in Node projects because of it's weird set up necessary with Travis CI, so I think we could look more into codecov.

shadowtime2000 avatar Mar 03 '21 17:03 shadowtime2000

But in my opinion, as Codecov seems more modern, it will surely have support for Deno sooner.

@Hunam6 actually you can do it already using their GH action that can be added to workflows

shadowtime2000 avatar Mar 03 '21 18:03 shadowtime2000

@ije Thoughts on this?

shadowtime2000 avatar Mar 05 '21 05:03 shadowtime2000

yeah, let's try it, but need to add more testings firstly...

ije avatar Mar 06 '21 10:03 ije