create-web3-dapp icon indicating copy to clipboard operation
create-web3-dapp copied to clipboard

Published 20 hours ago • verified publisher icon alchemyplatform

deleted duplicate code blocks

Open kenryu42 opened this issue 3 years ago • 1 comments

When running npx create-web3-dapp, it asked the same question twice and also installed the same package twice. The fix was made by removing the duplicate blocks of code in index.ts.

kenryu42 avatar Aug 09 '22 09:08 kenryu42

Didn't the code from https://github.com/Eversmile12/create-web3-dapp/blob/1af1ff89f33fe788fd92ab5cfa70bc273cdc214e/index.ts#L55

to https://github.com/Eversmile12/create-web3-dapp/blob/1af1ff89f33fe788fd92ab5cfa70bc273cdc214e/index.ts#L224

and code from https://github.com/Eversmile12/create-web3-dapp/blob/1af1ff89f33fe788fd92ab5cfa70bc273cdc214e/index.ts#L226

to https://github.com/Eversmile12/create-web3-dapp/blob/1af1ff89f33fe788fd92ab5cfa70bc273cdc214e/index.ts#L387

doing the exact same thing?

My pull request only removed one of the duplicated code block. Am I missing something here? 🤔

kenryu42 avatar Aug 16 '22 15:08 kenryu42

Close this pull request because the code owner has resolved the duplicate block himself.

kenryu42 avatar Aug 20 '22 06:08 kenryu42