alchemy-sdk-js icon indicating copy to clipboard operation
alchemy-sdk-js copied to clipboard

Published 20 hours ago • verified publisher icon alchemyplatform

Add settings to control request timeout

Open wong2 opened this issue 3 years ago • 4 comments

When using alchemy-sdk in my project, sometimes the call just stuck there for a long time, I'd like a setting for timeout seconds, so I can have better control on it with timeout & maxRetries

wong2 avatar Nov 01 '22 09:11 wong2

@wong2 thanks for the feature request! Are you primarily using the NFT APIs or the core json-rpc APIs?

thebrianchen avatar Nov 02 '22 22:11 thebrianchen

NFT APIs

wong2 avatar Nov 03 '22 03:11 wong2

NFT APIs

wong2 avatar Nov 03 '22 03:11 wong2

Hey @thebrianchen, I know some devs who'd be interested in working on this. Is there a budget for fixing this issue, and if so, how much?

I'd put this issue up on OpenQ.

Thanks!

ef3n9r98 avatar Dec 02 '22 17:12 ef3n9r98

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs

github-actions[bot] avatar Jan 02 '23 02:01 github-actions[bot]

Axios documentation, according to the documentation a timeout variable in the request config which can be set in the following way, timeout: <desired timeout>. This line can be added in the axios request function sendAxiosRequest where the config is initialized here This can also be added while initializing the SDK or even while calling a specific API (can be included as an argument), instead of having a default static value.

Would be happy to work on this if required.

Abbaskt avatar Jan 04 '23 11:01 Abbaskt

@Abbaskt We'd love to welcome any PRs you may have time for. Otherwise, we'll likely to get to this when it's more prioritized. Thanks!

thebrianchen avatar Jan 06 '23 16:01 thebrianchen