FR: add support for newly released NFT APIs

[thebrianchen]

Tracking issue for several new NFT endpoints that need to be added into the SDK:

• [X] computeRarity: Done in #148
• [X] searchContractMetadata Done in #163
• [X] summarizeNFTAttributes Done in #155
• [X] getNftSales: Done in #190
• [X] reportSpamContract (Not relevant to SDK)
• [X] getNftMetadataBatch: Done in #189
• [ ] getContractsForOwner: help wanted!

[xeno097]

Hi, I'd like to work on some of those missing NFT endpoints. I'd start with the computeRarity one and then maybe implement the others. Are there any guidelines I should follow to implement the feature?

[thebrianchen]

@xeno097 Thanks for offering to help! I'll work on a more holistic contributing document in the coming weeks.

For the NFT APIs:

• Add the top-level method into the NftNamespace and the underlying implementation in src/internal/nft-api.ts.
• Add unit tests in test/unit/nft-api.test.ts.
• Add a couple integration tests into test/integration/nft.test.ts.

Thanks! Just a heads up, we're working on changing the payloads in getNftSales, so some of the API surface area might change.

[xeno097]

Nice! I'll try to get something done over the weekend and keep an eye on the repo for the changes.

[xeno097]

@thebrianchen do you prefer that I keep working with smaller prs like the last one or a big one with everything? I'd prefer working with smaller ones because I think is tidier.

[thebrianchen]

Prefer smaller PRs as well! Easier to manage and review for sure.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs