albertony

There is a very similar global flag related to rclone's configuration file: ``` --password-command SpaceSepList Command for supplying password for encrypted configuration ``` With this implementation: https://github.com/rclone/rclone/blob/6a7e68aaf2d56df069eb31a46f2f6015a9429b24/fs/config/crypt.go#L173-L205 Did you look...

> I think gocritic makes good suggestions by-and-large. Yes, I think so too. I'm also considering looking more into its performance checks (https://go-critic.com/overview.html#checkers-from-the-performance-group), disabled by default, but seem interesting (at...

I improved the rule implementation some. If I'm not mistaken, the intention was to replace calls to any of the standard logging functions from log package with our own in...

Rebased and fixed conflicts

> This might involve making a new PR for 1-3 Done: https://github.com/rclone/rclone/pull/8009

Rebased this on branch gocritic-lint-basic which is basis of https://github.com/rclone/rclone/pull/8009, for now. When that PR is merged this will be rebased on master leaving only the additional - currently: ```...

> Perhaps we need a note to that effect in the ruleguard code so we see it when updating it and can click the clear cache button. Then that is...

> The ruleguard fixes all look like they will work, but I think some of them will trigger other lint warnings. > > Yes give the auto fix a try...

Hm, the linting now failed with a lot of issues from govet of the type: > lib\http\template.go:71:18: printf: non-constant format string in call to github.com/rclone/rclone/fs.Fatalf (govet) > fs.Fatalf(nil, fmt.Sprint("Fatal error...

> Yes I fixed a load of those recently for golangci lint v1.60.1 and that's the error I thought would happen, I guess having fixed a load of them recently!...