bulletproof-react
bulletproof-react copied to clipboard
Add styles files and added dark mode implementation (#186)
https://github.com/alan2207/bulletproof-react/issues/186
I'm not sure about the dark and light theme css files but if you want I can update this pr.
Deploy Preview for bulletproof-react-app ready!
| Name | Link |
|---|---|
| Latest commit | 71bc52b8607fabe1dc9d6545967b83cb4ff0e8e6 |
| Latest deploy log | https://app.netlify.com/sites/bulletproof-react-app/deploys/66cb22d130dd150008dc44de |
| Deploy Preview | https://deploy-preview-200--bulletproof-react-app.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Hey @maliksenpai , this is a very nice addition, thanks for contributing. Currently, it doesn't look ideal on all pages where some colors are hardcoded though, If you can make it look nice on all pages I will be more than happy to merge this... 🚀
@alan2207 Thank you for your kind words, but I didn't understand very well. Should I proceed by adding style files one by one for all pages? If so, should I add the codes I wrote in PR to all these style files?
@maliksenpai I was referring to the dark mode. Some components are not made to work with it, if you have the time, feel free to update them so they are compatible with light/dark mode. There is no need for the .css files though since all styling is done via Tailwind, a single style file is sufficient.
Okay I understand, I will review and update whether all components support dark mode or not. And I will delete themes .css files. I will work on ASAP.
@alan2207
hey @alan2207 I checked every page for dark mode and fixed all UI bugs. You can check it if you want, there may be points I missed (but I hope not).