purescript-simple-dom
purescript-simple-dom copied to clipboard
Much breaking very incompatible: Make interfaces ADT-value pairs instead of typeclass-type (Fixes #42)
Hey, TL;DR of this approach is provided in commit, discussed in #42.
Also, Sugar removed; tests tailored for buggy DOM implementation loosened (to match less buggy DOM implementations, such as Chromium); documentation regenerated with pulp docs; dependencies bumped.
Several issues arose while working on this PR.
Please comment on this code, I want to get this over with ASAP :)
If someone knows how to fix travis build — ping me.
I ran gulp and I got:
$ gulp
…
'docs' errored after 3.18 s
Error: psc-docs: error: unknown modules:
* Data.DOM.Simple.Sugar
* Data.DOM.Simple.Unsafe.Sugar
at ChildProcess.<anonymous> (/Users/foo/Programming/purescript-simple-dom/node_modules/gulp-purescript/index.js:7428:32)
at ChildProcess.emit (events.js:110:17)
at maybeClose (child_process.js:1015:16)
at Socket.<anonymous> (child_process.js:1183:11)
at Socket.emit (events.js:107:17)
at Pipe.close (net.js:485:12)
…
@kakkun61 right. This commit removes Sugar and Unsafe.Sugar. Which changes do I have to make for it to tell gulp that it shouldn't search for those?
I was manually launching test suite :(
Hey sorry, a delayed response. i couldn't get this pr to work with zombie + tests (had to update a bunch of stuff on master to get things to work at all) I've made a commit that makes the current test suite pass on ps 0.7.5 and removes all the warnings. Agree that a lot things need to be changed though. (just needed this on latest ps for a demo)
@aktowns :heart: :blue_heart: :purple_heart: :green_heart: