Alec Koumjian

Results 45 comments of Alec Koumjian

I am also experiencing this issue with several clients and tool schema definitions. As far as I can tell, the jsonschema being generated is valid, but the problem is that...

> Regarding the machine dependent results you observe, this depends on the compiler. You might need to turn off floating point contractions. I don't know what compiler you're using. If...

@matthewholman @cylon359 I think this is ready for your review. If it does get merged, it seems like a major version increment is warranted given the lack of backwards compatibility...

Rob and Matt suggested that maintaining two distinct paths for loading the coefficients wasn't necessary, which is why I came back with this simpler implementation (prior PR supported both implementations)....

I'm happy to accommodate whatever consensus is reached. If I do go back to the multiple file implementation, I will need to add back a couple small improvements and I...

It's not quite that straight forward, as there are two slightly different interfaces for how the masses are loaded and the coefficients generated. I would probably update both to have...

Yes, that was left over from the two implementations version. I was wondering if it might impact performance and was surprised that it benchmarked faster. Perhaps I could get it...

I'm definitely open to that. If we maintain the file type readers, I would consolidate both implementations into the assist_ephem struct.

If you want to branch off this, or merge it in, then clean it up, all are fine with me. I would like to get a version published to pypi...

@hannorein @matthewholman @mjuric I believe I've made all the requested changes. I removed all the unnecessary structs and refactored a bit to make loading the constant and mass data a...