akka-persistence-jdbc icon indicating copy to clipboard operation
akka-persistence-jdbc copied to clipboard

Published 20 hours ago • verified publisher icon akka

Add MySQL implementation

Open steventwheeler opened this issue 1 year ago • 3 comments

References #802

steventwheeler avatar Mar 07 '24 19:03 steventwheeler

Hi @steventwheeler,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

lightbend-cla-validator avatar Mar 07 '24 19:03 lightbend-cla-validator

I'm working on getting the CLA approved on my end but this change appears to resolve the issues I was seeing in my application.

steventwheeler avatar Mar 07 '24 19:03 steventwheeler

Hi @steventwheeler,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

lightbend-cla-validator avatar Mar 08 '24 15:03 lightbend-cla-validator

My employer has signed the CLA.

steventwheeler avatar Mar 08 '24 15:03 steventwheeler

My employer has signed the CLA.

Thanks for your contribution @steventwheeler.

However, for the CLA, the one that contributed needs to sign. The CLA checker will verify if user @steventwheeler has signed.

octonato avatar Mar 08 '24 15:03 octonato

My employer has signed the CLA.

Thanks for your contribution @steventwheeler.

However, for the CLA, the one that contributed needs to sign. The CLA checker will verify if user @steventwheeler has signed.

So, what I'm saying is, if you have their authorization to contribute code to Akka, then you can sign the CLA and the code can be accepted by Lightbend.

octonato avatar Mar 08 '24 15:03 octonato

My employer has signed the CLA.

Thanks for your contribution @steventwheeler. However, for the CLA, the one that contributed needs to sign. The CLA checker will verify if user @steventwheeler has signed.

So, what I'm saying is, if you have their authorization to contribute code to Akka, then you can sign the CLA and the code can be accepted by Lightbend.

I have signed it as well.

steventwheeler avatar Mar 08 '24 15:03 steventwheeler

Or at least I linked my GitHub account to your site and filled in the form. Is there another step that is required?

steventwheeler avatar Mar 08 '24 15:03 steventwheeler

I manually verified there is an entry in the CLA database 👍

johanandren avatar Mar 08 '24 15:03 johanandren

closing and reopen to re-trigger the CLA check

octonato avatar Mar 11 '24 08:03 octonato

Hey @steventwheeler, unfortunately we had an issue with the CI setup and didn't notice that the MySQLScalaJdbcDurableStateChangesByTagTest doesn't pass from this PR, I've disabled it in #806 where I fix the CI jobs, would be great if you could take a look, seems like the MySQLSequenceNextValUpdater doesn't work as expected.

johanandren avatar Mar 12 '24 14:03 johanandren

Hey @steventwheeler, unfortunately we had an issue with the CI setup and didn't notice that the MySQLScalaJdbcDurableStateChangesByTagTest doesn't pass from this PR, I've disabled it in #806 where I fix the CI jobs, would be great if you could take a look, seems like the MySQLSequenceNextValUpdater doesn't work as expected.

@johanandren Seems like MySQL can only increase the sequence by inserting and from the database itself. I will say the Oracle and SQLServer will be more easy to implement. Need some magic tricks that make MySQL work.

Roiocam avatar Apr 04 '24 04:04 Roiocam