Aidan Khoury

Results 32 comments of Aidan Khoury

> I wonder what the aim of this effort really is. I'm noticing for example, that there's no effort to make OpenSSL exportable in a CMake sense, i.e. there's no...

> As for how to make a `Configurations/CMakeLists.txt.tmpl`, it should really not be very hard. Simply do this: > > * copy everything from the current `CMakeLists.txt` that is before...

> Another thought: if you really want to wrap the OpenSSL in CMake scripts, it may be that the [ExternalProject](https://cmake.org/cmake/help/v3.17/module/ExternalProject.html) module does a good enough job already. I'm not sure,...

> I'm going to maintain that having CMake as a target config is problematic to say the least. It's quite clear that for a broad support, we'd have to make...

@dg0yt Regarding https://github.com/openssl/openssl/pull/20153#discussion_r1090218853 I agree with you here, and for other selfish reasons I would like to retain this ability as well. I think everyone should be quite well taken...

> In my attempt, I let src2obj create CMake object libraries. This generates a lot of object libraries... but build parameters can be controlled more individidually, and the target objects...

> > @dg0yt Regarding [#20153 (comment)](https://github.com/openssl/openssl/pull/20153#discussion_r1090218853) > > I agree with you here, and for other selfish reasons I would like to retain this ability as well. I think everyone...

> > That's my intention, always was... just gotta work out the kinks. > > (I'm actually surprised it took this long for someone to try to do something like...

The current state of the `cmake-support` branch resolves all of the possible PR suggestions with exception of @levitte's suggestion to have CMakeLists.txt as the build template. I for one think...

> Performed tests of the existing implementation using minimal CMake hello world project on Windows OS using native MSVC toolchain and CMake [FetchContent module](https://cmake.org/cmake/help/latest/module/FetchContent.html). Added following code to the project:...