zoxide icon indicating copy to clipboard operation
zoxide copied to clipboard

fix resolves symlink on `cd` at zsh

Open dalton-oliveira opened this issue 1 year ago • 9 comments

Description

Having _ZO_RESOLVE_SYMLINKS env var defined as "1", makes zoxide to chase symink of directory before adding it to the database. This behavior can be more coherent if the cd command also does the same. That's specially useful for APFS which is case insensitive by default. Closes #740.

What was done

Adds CHASE_LINKS option to cd, the same one used in pwd on zsh.

dalton-oliveira avatar Apr 01 '24 13:04 dalton-oliveira

@ajeetdsouza thank you for this amazing tool! It has already saving me a lot of keystrokes. Hope this PR is adequate and thanks for taking a look.

dalton-oliveira avatar Apr 01 '24 19:04 dalton-oliveira

Tested this branch using @dalton-oliveira's instructions here and it seems to totally fix my issue in #740 😍

jesseleite avatar Apr 01 '24 20:04 jesseleite

@dalton-oliveira just one question - why do we not use cd -P on Windows?

ajeetdsouza avatar Apr 03 '24 04:04 ajeetdsouza

@ajeetdsouza I was concerned to break something that I couldn't check manually. Just removed the conditional

dalton-oliveira avatar Apr 03 '24 11:04 dalton-oliveira

Thanks for doing this @dalton-oliveira! ❤️

jesseleite avatar Apr 11 '24 16:04 jesseleite

Just tested again since that last commit. Still works great / fixes my MacOS case sensitivity issues in #740 👍

jesseleite avatar Apr 29 '24 16:04 jesseleite

I have a similar issue to @jesseleite - would love to see this merged! 😄

duncanmcclean avatar May 16 '24 13:05 duncanmcclean

Hey @ajeetdsouza have just rebased with main. It's been here for a while so please feel free to reject the PR if you doesn't intent to merge it :)

dalton-oliveira avatar Jun 03 '24 17:06 dalton-oliveira

Thoughts on this one @ajeetdsouza? ...Would be huge little thing for us MacOS users, and it works great! 🙏🙏🙏

PS. Appreciate all you do! ❤️

jesseleite avatar Sep 04 '24 18:09 jesseleite