SponsorBlock icon indicating copy to clipboard operation
SponsorBlock copied to clipboard

Improve copy of start/end segment button

Open AlecRust opened this issue 3 years ago • 2 comments

Current Problem

Ever since using this (excellent) extension the labelling of the main "Segment Starts Now" button has irked me 🙂

Button labels should typically start with a verb i.e. the "action" that will be performed - "Start" in this case. Right now in both "states" of the button, the label starts with a noun - "Segment" in this case.

User shouldn't need to read somewhere in the middle of the button to determine the "state" the button is in.

Proposed Solution

  • Segment Starts Now -> Start Segment Now
  • Segment Ends Now -> End Segment Now

Screenshots

Before After
before after
  • [x] I agree to license my contribution under LGPL-3.0 or my contribution is from another project with a license compatible with LGPL-3.0

To test this pull request, follow the instructions in the wiki.

AlecRust avatar Aug 21 '22 11:08 AlecRust

One for a separate PR, but due to the importance of these start/stop buttons I feel like they could benefit from being full width, and include an icon for each state to further differentiate.

AlecRust avatar Aug 21 '22 11:08 AlecRust

Looks good!

Todo for me: trigger an update in crowdin instead of replacement before merging

ajayyy avatar Aug 22 '22 02:08 ajayyy