aiscript icon indicating copy to clipboard operation
aiscript copied to clipboard

fix: scannerが一部文字を無視する問題を修正

Open FineArchs opened this issue 1 year ago • 2 comments

#766 再発防止のため、各項目が場合分けを完結させるよう強制するようにしています。

FineArchs avatar Aug 25 '24 15:08 FineArchs

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 94.23077% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/parser/scanner.ts 94.23% 3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ
src/parser/scanner.ts 94.37% <94.23%> (+5.61%) :arrow_up:

... and 29 files with indirect coverage changes

codecov-commenter avatar Aug 25 '24 15:08 codecov-commenter

本題とはずれるけれど、this.stream.eofthis.stream.charがgetterなのが#732 と同じ理由であまり良くない?

salano-ym avatar Aug 26 '24 16:08 salano-ym

https://github.com/aiscript-dev/aiscript/actions/runs/10644756798/job/29509847385?pr=769

let文でtrue, false, nullのキーワードが弾かれていないらしい(masterでも確認したのでこのPRが原因ではないはず)

FineArchs avatar Aug 31 '24 11:08 FineArchs

条件を満たしているのでマージします。

FineArchs avatar Sep 02 '24 08:09 FineArchs