Icevision no longer works with the latest `sahi` release

[rafaelvp-db]

🐛 Bug

Describe the bug

Icevision stopped working with the latest sahi release (0.11.0).

When trying to do: from icevision.all import *

I get: ModuleNotFoundError: No module named 'sahi.model'

Looking at the code, I see the following:

sahi.model import DetectionModel

However, in the latest sahi release, the module structure contains a models subfolder, not model. For instance, in their predict.py script, there is the following:

from sahi.models.base import DetectionModel

One can look at their new folder/package structure here.

Two possible solutions:

• Change icevision code to reference sahi.models instead of sahi.model, or
• Pin sahi version to < 0.11.0

To Reproduce Steps to reproduce the behavior:

1. Install icevision
2. Try to run from icevision.all import *

Expected behavior

Icevision modules are imported successfully

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Ubuntu 18.04
• Python: 3.9

Additional context Add any other context about the problem here.

[rafaelvp-db]

btw, I'm willing to work on a fix for this

[rbavery]

@rafaelvp-db downgrading sahi to 0.10.8 solved the issue for me

[rbavery]

I think this requirement needs to be more restrictive so that only up to version 0.10.8 is installed: https://github.com/airctic/icevision/blob/master/setup.cfg#L37

[rbavery]

nevermind, there's already a PR up for this: https://github.com/airctic/icevision/pull/1147/files

[fcakyon]

I have also opened a PR adding support to latest sahi version: https://github.com/airctic/icevision/pull/1156