airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

[source-recurly] Corrects pattern to match which the exported format being used

Open bmulh opened this issue 1 year ago • 2 comments
trafficstars

What

Fixes https://github.com/airbytehq/airbyte/issues/46888. The connector definition is expecting %Y-%m-%dT%H:%M:%SZ for begin_time/end_time, but the spec and validation that the UI uses requires %Y-%m-%dT%H:%M:%S, which causes the inability to set a begin_time or end_time for the connector.

How

This PR updates the spec which is used by the UI for validation to match with what the connector actually expects. Allowing users to correctly set these datetimes.

Review guide

User Impact

There shouldn't be any user impact, since this is only updating the validation logic used on the frontend to match with what the connector already expected.

Can this PR be safely reverted and rolled back?

  • [ ] YES 💚
  • [ ] NO ❌

bmulh avatar Oct 10 '24 19:10 bmulh

@bmulh is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 10 '24 19:10 vercel[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 10 '24 19:10 CLAassistant

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 8:12pm

vercel[bot] avatar Oct 29 '24 19:10 vercel[bot]

Hello there! 👋 I noticed that this issue is still appearing in the Recurly connector. Do you have any plans to address it? Thanks so much for your hard work and support!

asterios-pantousas avatar Feb 04 '25 10:02 asterios-pantousas

Hey! +1 to that bug still appearing. Do you have plans to address it?

HCodeKeeper avatar Jun 23 '25 12:06 HCodeKeeper

Hey! +1 to that bug still appearing. Do you have plans to address it?

I'm happy to update this and get it ready to merge, but since I don't have the ability to merge it myself, it will need to be handled by the Airbyte team—which is why it's still pending.

bmulh avatar Jun 23 '25 12:06 bmulh