airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

Source Gong: Add extensive calls stream

Open krishan711 opened this issue 1 year ago • 3 comments

What

Adds a new stream to the gong connector that implements the extensive calls endpoint so you can access richer information about the calls.

How

Extends the manifest to include an extensive_calls stream (i didn't want to break the existing stream to do this)

Review guide

Unsure

User Impact

New stream available for use (extensive_calls)

Can this PR be safely reverted and rolled back?

  • [X] YES 💚
  • [ ] NO ❌

krishan711 avatar May 23 '24 16:05 krishan711

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 3:54pm

vercel[bot] avatar May 23 '24 16:05 vercel[bot]

closes #23776

krishan711 avatar May 23 '24 16:05 krishan711

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 23 '24 16:05 CLAassistant

Overall looks great, let's get this to green CI (formatting check might be borked on our side, will fix on Tuesday, but version change will be required) and then get this merged!

Thanks that's great. it looks like the "Connectors Version Increment Check" is failing cos I'm not a contributor so not sure how to get around that. Happy to fix formatting if you can point me in the right direction? thanks!

krishan711 avatar May 25 '24 20:05 krishan711

@natikgadzhi i would love another review if you have a minute? i had to rebase everything because of the big format change PR that went in.

krishan711 avatar Jun 05 '24 10:06 krishan711

@marcosmarxm thanks for the comments. i think I've addressed them all now, apologies if i've left something out pls do let me know

krishan711 avatar Jun 05 '24 13:06 krishan711

@krishan711 can you check the conflicts and solve them?

marcosmarxm avatar Jun 07 '24 15:06 marcosmarxm

@krishan711 let's figure out what to do with the composite PK in the stream. This is the biggest problem, once you figure it out, we're happy to merge.

natikgadzhi avatar Jun 12 '24 23:06 natikgadzhi

@krishan711 let's figure out what to do with the composite PK in the stream. This is the biggest problem, once you figure it out, we're happy to merge.

@natikgadzhi I've used a transformation to make this a field at the top level now 👍

krishan711 avatar Jun 13 '24 08:06 krishan711

Running CI tests @krishan711

marcosmarxm avatar Jun 13 '24 17:06 marcosmarxm

Re-running CI, we've fixed formatting on master. Let's see how that performs. Left a nit on how you set primary key, but otherwise seems okay.

Setting to automerge, contingent on @marcosmarxm review.

natikgadzhi avatar Jun 14 '24 18:06 natikgadzhi

Vercel was fixed on master, but the check did not propagate yet

natikgadzhi avatar Jun 14 '24 18:06 natikgadzhi

Re-running CI, we've fixed formatting on master. Let's see how that performs. Left a nit on how you set primary key, but otherwise seems okay.

Setting to automerge, contingent on @marcosmarxm review.

thanks I've merged your suggestion.

krishan711 avatar Jun 17 '24 08:06 krishan711