airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

✨Source Coda: Make Connector Compatible with Builder

Open pabloescoder opened this issue 1 year ago • 2 comments

What

Makes the connector compatible with the Builder UI

How

  • Bump minor version
  • Remove $parameters
  • Use Inline Schema
  • Make it compatible with the Builder

User Impact

Non impacting, done for maintainability

Can this PR be safely reverted and rolled back?

  • [x] YES 💚

pabloescoder avatar May 22 '24 19:05 pabloescoder

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 7:57pm

vercel[bot] avatar May 22 '24 19:05 vercel[bot]

The cursor pagination for this source was incorrect. It was using the href key of the last record to paginate, this caused errors in CI. According to the API documentation for pagination, there is a nextPageLink field in the result that should be used for pagination.

Also since the rows stream has 2 parent streams (docs and table), a table can be only under one particular doc. Assume there are 2 docs, X and Y. X has a table X_A and Y has no table. So when the stream tries to get the rows for doc X and table X_A using the url (.../docs/X/table/X_A) it will succeed, however since both docs and tables are parent streams, the stream will also try to get rows for doc Y and table X_A using the url (.../docs/Y/table/X_A) which will give a 404 not found error since table X_A exists under doc X and not Y So I've added an error handler for the rows stream to ignore this case.

pabloescoder avatar May 22 '24 23:05 pabloescoder