airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

✨Source Xero: Migrate Python CDK to Low-code CDK

Open btkcodedev opened this issue 1 year ago • 10 comments

What

Migrating Source Xero to Low-Code CDK Closes airbytehq/airbyte-internal-issues#7187

How

Developed using (Configuration Based Source) low-code CDK

Recommended reading order

  1. spec.yaml
  2. manifest.yaml
  3. schemas/*

Tests

Integration & Acceptance
  • Test successful with full refresh

Screenshot from 2024-04-07 00-28-47

🚨 User Impact 🚨

  • Migration to low-code

btkcodedev avatar Apr 10 '24 07:04 btkcodedev

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 6:30pm

vercel[bot] avatar Apr 10 '24 07:04 vercel[bot]

Need help with incremental sync, currently, the TestTwoSequentialReads Test is failing, The backend is not changing the slice as per timestamp I think, Comments by reviewers would be very helpful image

btkcodedev avatar Apr 10 '24 07:04 btkcodedev

Inline Schema ✅ Poetry lock file ✅ No breaking change ✅ Docs updated ✅ Code formatted :white_check_mark:

Need help with incremental sync

btkcodedev avatar Apr 10 '24 07:04 btkcodedev

Reviewers, please change the access_token in the cloud for running the CI

btkcodedev avatar Apr 16 '24 17:04 btkcodedev

@btkcodedev please write your requests in slack chat to speed up process and can you specify their how we need change access_token ?

lazebnyi avatar Apr 24 '24 22:04 lazebnyi

@lazebnyi The access_token expires every 45 minutes as per my knowledge, As it only supports authorization code and needs an org account for other types of Oauth 2.0, the access_token needs to be updated whenever it expires to pass CI, Ref - https://github.com/airbytehq/airbyte/pull/36956#pullrequestreview-1995806856

Whenever you're ready, please ping me for the freshly prepared credentials with access_token for running the CI, I've confirmed the working on local Results: image

btkcodedev avatar Apr 25 '24 07:04 btkcodedev

Hi @darynaishchenko, All comments are resolved and brought back the unit_tests, All passing in local, the access_token is expired in the cloud, It has a very short duration, please ping me @btkcodedev on slack for getting freshly prepared creds during next review

btkcodedev avatar May 10 '24 08:05 btkcodedev

image

btkcodedev avatar May 10 '24 08:05 btkcodedev

CI all green, All comments resolved, Please continue merge process :bow:

btkcodedev avatar May 10 '24 11:05 btkcodedev

CI all green, All comments resolved, Please continue merge process 🙇

@btkcodedev I'm going to run regression tests on your pr. Let you know the results. Thanks!

darynaishchenko avatar May 10 '24 11:05 darynaishchenko

Thank u team!!

ak-workit avatar May 22 '24 23:05 ak-workit