airbyte
airbyte copied to clipboard
✨Source Asana: Migrate Python CDK to Low-code CDK
What
Migrating Source Asana to Low-Code CDK Closes airbytehq/airbyte-internal-issues#7057
How
Developed using (Configuration Based Source) low-code CDK
Recommended reading order
spec.yamlmanifest.yamlschemas/*
Tests
Integration & Acceptance
- Test successfull
🚨 User Impact 🚨
- Migration to low-code
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| airbyte-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 4, 2024 5:11pm |
Inline Schema ✅ Poetry lock file ✅ Breaking change mentioned in metadata ✅ Performed config migrations ✅ Added migrations.md docs file ✅ Docs updated ✅ Formatted :white_check_mark:
Test results: All pass
Marking PR as ready to merge
Resolved comments
Updated: Comments resolved (With fix for exposure of extra fields removed)
Made the changes CI is passing :white_check_mark:
@askarpets All comments resolved and CI is passing, Please continue merge process :bow:
Oh sorry about that, will do
Fixed
The exposure problem is fixed, Please continue the merge process @askarpets
Resolved all comments CI green
@askarpets Any update here?
Resolved comments and CI green
@askarpets
@askarpets, @lazebnyi Any updates here
@askarpets, Does the opt field require a custom component? which declarative component inheritance would be opt for retrieving the response and modifying the request parameters?
Any suggestion
@askarpets, Does the opt field require a custom component? which declarative component inheritance would be opt for retrieving the response and modifying the request parameters?
I think you could just run the read command with --debug flag and get needed request params from the URLs and then add them to your manifest. Does that make sense?
@askarpets But when looking at the implementation, it has something to do with schema right, Can you suggest anything for that 🙇 https://github.com/airbytehq/airbyte/pull/36951/files#diff-1a7657fc907cd4cc2de94c74edee1c1260b0e5549fd575880df07b27f19de530L66 Thanks again!
@askarpets But when looking at the implementation, it has something to do with schema right, Can you suggest anything for that 🙇 https://github.com/airbytehq/airbyte/pull/36951/files#diff-1a7657fc907cd4cc2de94c74edee1c1260b0e5549fd575880df07b27f19de530L66 Thanks again!
It takes fields from schemas and converts them to opt_fields values. Since the schemas are static for this connector, you should be able to just hardcode this param. Otherwise, a custom requester should be implemented with overridden request_params method - please see example implementation.
@askarpets, I've implemented the customRequester, but the problem is, Other request parameters are not being passed right now and substreams fail to fetch data. I've commented on the opt_field parameter line, but still, it doesn't pass, Could you please write your comments on the custom requester :pray: https://github.com/airbytehq/airbyte/pull/36951/files#diff-e10a6dd97d87fd5e5668385aaac9dfb0de57334b3ca29f6830ac4bcf038c430bR18
@btkcodedev I made all needed changes to make it work.
Thanks @askarpets :bow:
All the comments are resolved I think, Please continue :pray: Thanks again!