airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

✨Source SurveyMonkey: Add new streams ContactLists, SurveyFolders, SurveyCategories, Questions

Open btkcodedev opened this issue 2 years ago • 3 comments

What

Closes airbytehq/airbyte-internal-issues#962 Closes airbytehq/airbyte-internal-issues#961 Closes airbytehq/airbyte-internal-issues#960 Closes airbytehq/airbyte-internal-issues#959

Enhancement

New streams:

  • ContactLists
  • SurveyFolders
  • SurveyCategories
  • Questions

Recommended reading order

  1. source_surveymonkey/configured_catalog.json
  2. source_surveymonkey/source.py
  3. source_surveymonkey/schemas/*

🚨 User Impact 🚨

No breaking changes

Pre-merge Checklist

Updating a connector

Community member or Airbyter [Yes]

  • [x] Grant edit access to maintainers (instructions)
  • [x] Secrets in the connector's spec are annotated with airbyte_secret
  • [x] Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • [x] Issue acceptance criteria met
  • [x] PR name follows PR naming conventions
  • [x] Documentation which references the generator is updated as needed

btkcodedev avatar Nov 18 '23 05:11 btkcodedev

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2024 3:11pm

vercel[bot] avatar Nov 18 '23 05:11 vercel[bot]

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • [ ] PR name follows PR naming conventions
  • [ ] Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • [ ] Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • [ ] You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • [ ] Secrets in the connector's spec are annotated with airbyte_secret
  • [ ] All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • [ ] Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • [ ] Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • [ ] If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

github-actions[bot] avatar Nov 18 '23 05:11 github-actions[bot]

@marcosmarxm Raised this PRs for solving issues https://github.com/airbytehq/airbyte-internal-issues/issues/962 https://github.com/airbytehq/airbyte-internal-issues/issues/961 https://github.com/airbytehq/airbyte-internal-issues/issues/960 https://github.com/airbytehq/airbyte-internal-issues/issues/959

btkcodedev avatar Nov 18 '23 05:11 btkcodedev

Closing due to inactivity.

btkcodedev avatar May 21 '24 16:05 btkcodedev