airbyte
airbyte copied to clipboard
Source Hubspot: enable SAT high strictness
What
Resolving: https://github.com/airbytehq/airbyte/issues/19048
How
Updating SAT config and expected records.
Recommended reading order
x.javay.python
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
- [ ] Community member? Grant edit access to maintainers (instructions)
- [ ] Secrets in the connector's spec are annotated with
airbyte_secret - [ ] Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run
./gradlew :airbyte-integrations:connectors:<name>:integrationTest. - [ ] Code reviews completed
- [ ] Documentation updated
- [ ] Connector's
README.md - [ ] Connector's
bootstrap.md. See description and examples - [ ]
docs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog example - [ ]
docs/integrations/README.md - [ ]
airbyte-integrations/builds.md
- [ ] Connector's
- [ ] PR name follows PR naming conventions
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
- [ ] Create a non-forked branch based on this PR and test the below items on it
- [ ] Build is successful
- [ ] If new credentials are required for use in CI, add them to GSM. Instructions.
- [ ]
/test connector=connectors/<name>command is passing - [ ] New Connector version released on Dockerhub by running the
/publishcommand described here - [ ] After the connector is published, connector added to connector index as described here
- [ ] Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector
Community member or Airbyter
- [ ] Grant edit access to maintainers (instructions)
- [ ] Secrets in the connector's spec are annotated with
airbyte_secret - [ ] Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run
./gradlew :airbyte-integrations:connectors:<name>:integrationTest. - [ ] Code reviews completed
- [ ] Documentation updated
- [ ] Connector's
README.md - [ ] Connector's
bootstrap.md. See description and examples - [ ] Changelog updated in
docs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog example
- [ ] Connector's
- [ ] PR name follows PR naming conventions
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
- [ ] Create a non-forked branch based on this PR and test the below items on it
- [ ] Build is successful
- [ ] If new credentials are required for use in CI, add them to GSM. Instructions.
- [ ]
/test connector=connectors/<name>command is passing - [ ] New Connector version released on Dockerhub and connector version bumped by running the
/publishcommand described here
Connector Generator
- [ ] Issue acceptance criteria met
- [ ] PR name follows PR naming conventions
- [ ] If adding a new generator, add it to the list of scaffold modules being tested
- [ ] The generator test modules (all connectors with
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changes - [ ] Documentation which references the generator is updated as needed
Tests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.
/test connector=connectors/source-hubspot
:clock2: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3995254652 :x: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3995254652 :bug: https://gradle.com/s/z2snwl7vh2hge
Build Failed
Test summary info:
=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream compa...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
============= 1 failed, 30 passed, 2 skipped in 242.03s (0:04:02) ==============
/test connector=connectors/source-hubspot
:clock2: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3995815209 :x: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3995815209 :bug: https://gradle.com/s/6sgxtu6peij6e
Build Failed
Test summary info:
=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream conta...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
============= 1 failed, 30 passed, 2 skipped in 241.60s (0:04:01) ==============
/test connector=connectors/source-hubspot
:clock2: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4009548540 :white_check_mark: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4009548540 Python tests coverage:
Name Stmts Miss Cover
-------------------------------------------------
source_hubspot/errors.py 6 0 100%
source_hubspot/constants.py 2 0 100%
source_hubspot/__init__.py 2 0 100%
source_hubspot/helpers.py 70 10 86%
source_hubspot/source.py 90 23 74%
source_hubspot/streams.py 837 269 68%
-------------------------------------------------
TOTAL 1007 302 70%
Name Stmts Miss Cover
-------------------------------------------------
source_hubspot/errors.py 6 0 100%
source_hubspot/constants.py 2 0 100%
source_hubspot/__init__.py 2 0 100%
source_hubspot/helpers.py 70 3 96%
source_hubspot/streams.py 837 77 91%
source_hubspot/source.py 90 18 80%
-------------------------------------------------
TOTAL 1007 98 90%
Name Stmts Miss Cover Missing
----------------------------------------------------------------------------------
source_acceptance_test/base.py 12 4 67% 16-19
source_acceptance_test/config.py 141 5 96% 87, 93, 239, 243-244
source_acceptance_test/conftest.py 211 95 55% 36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
source_acceptance_test/plugin.py 69 25 64% 22-23, 31, 36, 120-140, 144-148
source_acceptance_test/tests/test_core.py 402 115 71% 53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
source_acceptance_test/tests/test_incremental.py 160 14 91% 58-65, 70-83, 246
source_acceptance_test/utils/asserts.py 39 2 95% 62-63
source_acceptance_test/utils/common.py 94 10 89% 16-17, 32-38, 72, 75
source_acceptance_test/utils/compare.py 62 23 63% 21-51, 68, 97-99
source_acceptance_test/utils/connector_runner.py 133 33 75% 24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
source_acceptance_test/utils/json_schema_helper.py 107 13 88% 30-31, 38, 41, 65-68, 96, 120, 192-194
----------------------------------------------------------------------------------
TOTAL 1609 339 79%
Build Passed
Test summary info:
=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
================== 31 passed, 2 skipped in 278.99s (0:04:38) ===================
/test connector=connectors/source-hubspot
:clock2: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4026008303 :x: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4026008303 :bug: https://gradle.com/s/jhd5vtohycppi
Build Failed
Test summary info:
=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream conta...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
FAILED test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
============= 5 failed, 26 passed, 2 skipped in 783.83s (0:13:03) ==============
/test connector=connectors/source-hubspot
:clock2: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4028067690 :x: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4028067690 :bug: https://gradle.com/s/ynn2wfsxeayk4
Build Failed
Test summary info:
=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream conta...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
============= 1 failed, 30 passed, 2 skipped in 263.99s (0:04:23) ==============
/test connector=connectors/source-hubspot
:clock2: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4036381163 :x: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4036381163 :bug: https://gradle.com/s/zmnfmynnfcqzq
Build Failed
Test summary info:
=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream conta...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
============= 1 failed, 30 passed, 2 skipped in 232.86s (0:03:52) ==============
/test connector=connectors/source-hubspot
:clock2: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4049980093 :x: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4049980093 :bug: https://gradle.com/s/nondrip65y4aq
Build Passed
Test summary info:
=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
================== 31 passed, 2 skipped in 240.36s (0:04:00) ===================
/test connector=connectors/source-hubspot
:clock2: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4052514881 :x: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4052514881 :bug: https://gradle.com/s/n5nqbmn6uyryw
Build Passed
Test summary info:
=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 37 passed, 2 skipped in 220.66s (0:03:40) ===================
/test connector=connectors/source-hubspot
:clock2: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4055798837 :white_check_mark: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4055798837 Python tests coverage:
Name Stmts Miss Cover
-------------------------------------------------
source_hubspot/errors.py 6 0 100%
source_hubspot/constants.py 2 0 100%
source_hubspot/__init__.py 2 0 100%
source_hubspot/helpers.py 70 10 86%
source_hubspot/source.py 90 23 74%
source_hubspot/streams.py 841 269 68%
-------------------------------------------------
TOTAL 1011 302 70%
Name Stmts Miss Cover
-------------------------------------------------
source_hubspot/errors.py 6 0 100%
source_hubspot/constants.py 2 0 100%
source_hubspot/__init__.py 2 0 100%
source_hubspot/helpers.py 70 3 96%
source_hubspot/streams.py 841 78 91%
source_hubspot/source.py 90 18 80%
-------------------------------------------------
TOTAL 1011 99 90%
Name Stmts Miss Cover Missing
----------------------------------------------------------------------------------
source_acceptance_test/base.py 12 4 67% 16-19
source_acceptance_test/config.py 141 5 96% 87, 93, 239, 243-244
source_acceptance_test/conftest.py 211 95 55% 36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
source_acceptance_test/plugin.py 69 25 64% 22-23, 31, 36, 120-140, 144-148
source_acceptance_test/tests/test_core.py 476 117 75% 53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
source_acceptance_test/tests/test_incremental.py 160 14 91% 58-65, 70-83, 246
source_acceptance_test/utils/asserts.py 39 2 95% 62-63
source_acceptance_test/utils/common.py 94 10 89% 16-17, 32-38, 72, 75
source_acceptance_test/utils/compare.py 62 23 63% 21-51, 68, 97-99
source_acceptance_test/utils/connector_runner.py 133 33 75% 24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
source_acceptance_test/utils/json_schema_helper.py 114 13 89% 31-32, 39, 42, 66-69, 97, 121, 203-205
----------------------------------------------------------------------------------
TOTAL 1690 341 80%
Build Passed
Test summary info:
=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 37 passed, 2 skipped in 295.30s (0:04:55) ===================
/test connector=connectors/source-hubspot
:clock2: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4075667097 :white_check_mark: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4075667097 Python tests coverage:
Name Stmts Miss Cover
-------------------------------------------------
source_hubspot/errors.py 6 0 100%
source_hubspot/constants.py 2 0 100%
source_hubspot/__init__.py 2 0 100%
source_hubspot/helpers.py 70 10 86%
source_hubspot/source.py 90 23 74%
source_hubspot/streams.py 841 269 68%
-------------------------------------------------
TOTAL 1011 302 70%
Name Stmts Miss Cover
-------------------------------------------------
source_hubspot/errors.py 6 0 100%
source_hubspot/constants.py 2 0 100%
source_hubspot/__init__.py 2 0 100%
source_hubspot/helpers.py 70 3 96%
source_hubspot/streams.py 841 78 91%
source_hubspot/source.py 90 18 80%
-------------------------------------------------
TOTAL 1011 99 90%
Name Stmts Miss Cover Missing
----------------------------------------------------------------------------------
source_acceptance_test/base.py 12 4 67% 16-19
source_acceptance_test/config.py 141 5 96% 87, 93, 239, 243-244
source_acceptance_test/conftest.py 211 95 55% 36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
source_acceptance_test/plugin.py 69 25 64% 22-23, 31, 36, 120-140, 144-148
source_acceptance_test/tests/test_core.py 476 117 75% 53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
source_acceptance_test/tests/test_incremental.py 160 14 91% 58-65, 70-83, 246
source_acceptance_test/utils/asserts.py 39 2 95% 62-63
source_acceptance_test/utils/common.py 94 10 89% 16-17, 32-38, 72, 75
source_acceptance_test/utils/compare.py 62 23 63% 21-51, 68, 97-99
source_acceptance_test/utils/connector_runner.py 133 33 75% 24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
source_acceptance_test/utils/json_schema_helper.py 114 13 89% 31-32, 39, 42, 66-69, 97, 121, 203-205
----------------------------------------------------------------------------------
TOTAL 1690 341 80%
Build Passed
Test summary info:
=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 37 passed, 2 skipped in 269.25s (0:04:29) ===================
/test connector=connectors/source-hubspot
:clock2: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4076077332 :x: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4076077332 :bug: https://gradle.com/s/ttp6p2ou5dq3e
Build Failed
Test summary info:
Could not find result summary
:clock2: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4076077332 :x: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4076077332 :bug: https://gradle.com/s/p5to3q2hebxtm
Build Failed
Test summary info:
Could not find result summary
/test connector=connectors/source-hubspot
:clock2: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4079213670 :white_check_mark: connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4079213670 Python tests coverage:
Name Stmts Miss Cover
-------------------------------------------------
source_hubspot/errors.py 6 0 100%
source_hubspot/constants.py 2 0 100%
source_hubspot/__init__.py 2 0 100%
source_hubspot/helpers.py 70 3 96%
source_hubspot/streams.py 841 78 91%
source_hubspot/source.py 90 18 80%
-------------------------------------------------
TOTAL 1011 99 90%
Name Stmts Miss Cover
-------------------------------------------------
source_hubspot/errors.py 6 0 100%
source_hubspot/constants.py 2 0 100%
source_hubspot/__init__.py 2 0 100%
source_hubspot/helpers.py 70 10 86%
source_hubspot/source.py 90 23 74%
source_hubspot/streams.py 841 269 68%
-------------------------------------------------
TOTAL 1011 302 70%
Name Stmts Miss Cover Missing
-------------------------------------------------------------------------------------
connector_acceptance_test/base.py 12 4 67% 16-19
connector_acceptance_test/config.py 141 5 96% 87, 93, 239, 243-244
connector_acceptance_test/conftest.py 211 95 55% 36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
connector_acceptance_test/plugin.py 69 25 64% 22-23, 31, 36, 120-140, 144-148
connector_acceptance_test/tests/test_core.py 476 117 75% 53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
connector_acceptance_test/tests/test_incremental.py 160 14 91% 58-65, 70-83, 246
connector_acceptance_test/utils/asserts.py 39 2 95% 62-63
connector_acceptance_test/utils/common.py 94 10 89% 16-17, 32-38, 72, 75
connector_acceptance_test/utils/compare.py 62 23 63% 21-51, 68, 97-99
connector_acceptance_test/utils/connector_runner.py 133 33 75% 24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
connector_acceptance_test/utils/json_schema_helper.py 114 13 89% 31-32, 39, 42, 66-69, 97, 121, 203-205
-------------------------------------------------------------------------------------
TOTAL 1690 341 80%
Build Passed
Test summary info:
=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 37 passed, 2 skipped in 245.27s (0:04:05) ===================
Airbyte Code Coverage
There is no coverage information present for the Files changed
| Total Project Coverage | 24.52% | :x: |
|---|