airbyte
airbyte copied to clipboard
Source Jira: Small fix in the board stream
What
Some boards don't have projects associated with them. Thus, some records don't have the fields inside the location dict. I created a fail-safe approach.
How
Use get instead. The project fields will be None if no project is available.
Recommended reading order
- streams.py
🚨 User Impact 🚨
Boards stream won't break
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
- [x] Grant edit access to maintainers (instructions)
- [x] Secrets in the connector's spec are annotated with
airbyte_secret - [ ] Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run
./gradlew :airbyte-integrations:connectors:<name>:integrationTest. - [ ] Code reviews completed
- [ ] Documentation updated
- [ ] Connector's
README.md - [ ] Connector's
bootstrap.md. See description and examples - [ ] Changelog updated in
docs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog example
- [ ] Connector's
- [x] PR name follows PR naming conventions
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
- [ ] Create a non-forked branch based on this PR and test the below items on it
- [ ] Build is successful
- [ ] If new credentials are required for use in CI, add them to GSM. Instructions.
- [ ]
/test connector=connectors/<name>command is passing - [ ] New Connector version released on Dockerhub and connector version bumped by running the
/publishcommand described here
Tests
Unit
Passing
Integration
Passing
Acceptance
Passing
/test connector=connectors/source-jira
:clock2: connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/4023520367 :white_check_mark: connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/4023520367 Python tests coverage:
Name Stmts Miss Cover
---------------------------------------------
source_jira/utils.py 21 0 100%
source_jira/__init__.py 2 0 100%
source_jira/source.py 42 2 95%
source_jira/streams.py 641 63 90%
---------------------------------------------
TOTAL 706 65 91%
Name Stmts Miss Cover Missing
----------------------------------------------------------------------------------
source_acceptance_test/base.py 12 4 67% 16-19
source_acceptance_test/config.py 141 5 96% 87, 93, 239, 243-244
source_acceptance_test/conftest.py 211 95 55% 36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
source_acceptance_test/plugin.py 69 25 64% 22-23, 31, 36, 120-140, 144-148
source_acceptance_test/tests/test_core.py 402 115 71% 53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
source_acceptance_test/tests/test_incremental.py 160 14 91% 58-65, 70-83, 246
source_acceptance_test/utils/asserts.py 39 2 95% 62-63
source_acceptance_test/utils/common.py 94 10 89% 16-17, 32-38, 72, 75
source_acceptance_test/utils/compare.py 62 23 63% 21-51, 68, 97-99
source_acceptance_test/utils/connector_runner.py 133 33 75% 24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
source_acceptance_test/utils/json_schema_helper.py 107 13 88% 30-31, 38, 41, 65-68, 96, 120, 192-194
----------------------------------------------------------------------------------
TOTAL 1609 339 79%
Build Passed
Test summary info:
=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
================== 29 passed, 2 skipped in 368.87s (0:06:08) ===================
Thank you for the review! I applied the changes requested @marcosmarxm
Bump. encountered this error too
/test connector=connectors/source-jira
:clock2: connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/4315908407 :white_check_mark: connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/4315908407 Python tests coverage:
Name Stmts Miss Cover
---------------------------------------------
source_jira/utils.py 21 0 100%
source_jira/__init__.py 2 0 100%
source_jira/source.py 42 2 95%
source_jira/streams.py 640 63 90%
---------------------------------------------
TOTAL 705 65 91%
Build Passed
Test summary info:
=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
================== 35 passed, 2 skipped in 548.74s (0:09:08) ===================
Awesome fix. When can we expect a release?