airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

Added updates to Jira source to include issue components and fixes to README files

Open swentling87 opened this issue 3 years ago • 1 comments
trafficstars

Added updates to Jira source to include issue components and fixes to README files

What This PR solves the problem of returning the components of an issue which is extremely important for analysis and tracking.

How I added the components field in the fields object present in the stream issues.

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

User Impact

No breaking changes, just adding to the response

Updating a connector

Community member or Airbyter

  • [ ] Grant edit access to maintainers (instructions)
  • [ ] Secrets in the connector's spec are annotated with airbyte_secret
  • [ ] Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • [ ] Code reviews completed
  • [ ] Documentation updated
    • [ ] Connector's README.md
    • [ ] Connector's bootstrap.md. See description and examples
    • [ ] Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • [ ] PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • [ ] Create a non-forked branch based on this PR and test the below items on it
  • [ ] Build is successful
  • [ ] If new credentials are required for use in CI, add them to GSM. Instructions.
  • [ ] /test connector=connectors/<name> command is passing
  • [ ] New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

swentling87 avatar Jul 29 '22 08:07 swentling87

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 29 '22 08:07 CLAassistant

/test connector=connectors/source-jira

:clock2: connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/2777491786 :x: connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/2777491786 :bug: https://gradle.com/s/nwkpzd4sxwa5u

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 1 failed, 32 passed, 2 skipped in 160.34s (0:02:40) ==============

marcosmarxm avatar Aug 01 '22 19:08 marcosmarxm

/test connector=connectors/source-jira

marcosmarxm avatar Aug 03 '22 21:08 marcosmarxm

/test connector=connectors/source-jira

:clock2: connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/2796767625 :x: connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/2796767625 :bug: https://gradle.com/s/opdi4artmcx2k

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======== 1 failed, 33 passed, 2 skipped, 1 warning in 173.47s (0:02:53) ========

marcosmarxm avatar Aug 04 '22 12:08 marcosmarxm

@marcosmarxm Is there anything I can do for this right now? I'm seeing some failing tests but it's not clear that they're related to what I've submitted. Let me know, thanks!

swentling87 avatar Aug 04 '22 17:08 swentling87

/test connector=connectors/source-jira

:clock2: connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/2827920434 :white_check_mark: connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/2827920434 Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        82      6    93%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  77     17    78%
source_acceptance_test/tests/test_core.py              355    107    70%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                 1023    247    76%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 38 passed, 2 skipped in 169.75s (0:02:49) ===================

marcosmarxm avatar Aug 09 '22 19:08 marcosmarxm

/publish connector=connectors/source-jira

:clock2: Publishing the following connectors:
connectors/source-jira
https://github.com/airbytehq/airbyte/actions/runs/2828009202

Connector Did it publish? Were definitions generated?
connectors/source-jira :white_check_mark: :x:

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

marcosmarxm avatar Aug 09 '22 20:08 marcosmarxm