airbyte-platform
airbyte-platform copied to clipboard
fix issue #49938: missing property in helm airbyte/value.yaml (helm v1.3.1)
trafficstars
What
there is a somewhat "breaking" change introduced by this commit. https://github.com/airbytehq/airbyte-platform/commit/02e3c972338cc8a63364528d137ae52beec2f4a0
I'm not sure the context of this commit, but as far as I understand, global.serviceAccountName should be used across each services in airbyte.
however, if the purpose is to let "workload-launcher" to use its own serviceaccount, then airbyte/values.yaml should be updated because this is where most end-users refer to since there is no changelog for helm charts.
How
to fix this issue https://github.com/airbytehq/airbyte/issues/49938
Recommended reading order
value.yaml
Can this PR be safely reverted and rolled back?
- [x] YES 💚
- [ ] NO ❌