airbyte-platform
airbyte-platform copied to clipboard
feat(temporal): allow customization of SSL mode for external db
trafficstars
What
Due to a recent chart change, it is not possible to disable SSL for external databases. This change to the temporal chart allows to configure the SSL value for both internal and external databases.
Fixes https://github.com/airbytehq/airbyte/issues/43328
How
By adding a new chart value to enable or disable SSL for database in the global section.
global:
database:
type: external
ssl:
enabled: false
This parameter is not related to the database type.
Note: The new value could be moved to the temporal section if needed. I thought that since the SSL flags were initially introduced in the global section I would add the new value there as well:
#####
# How the SSL flags were introduced
#####
{{- if eq .Values.global.database.type "external" }}
# Assume an external database requires SSL.
- name: POSTGRES_TLS_ENABLED
value: "true"
- name: POSTGRES_TLS_DISABLE_HOST_VERIFICATION
value: "true"
- name: SQL_TLS_ENABLED
value: "true"
- name: SQL_TLS_DISABLE_HOST_VERIFICATION
value: "true"
{{- end }}
Recommended reading order
- /
Can this PR be safely reverted and rolled back?
- [x] YES 💚 but this could break the chart as it was the case with https://github.com/airbytehq/airbyte-platform/commit/4731a0b246eb9767ec61faf211097c8f0f68fb5b
- [ ] NO ❌