airbyte-platform icon indicating copy to clipboard operation
airbyte-platform copied to clipboard

fix(helm): correctly format imagePullSecrets for metrics deployment

Open jakub-qg opened this issue 1 year ago • 2 comments
trafficstars

What

Error: YAML parse error on airbyte/charts/metrics/templates/deployment.yaml: error converting YAML to JSON: yaml: line 27: did not find expected key
helm.go:84: [debug] error converting YAML to JSON: yaml: line 27: did not find expected key
YAML parse error on airbyte/charts/metrics/templates/deployment.yaml

Before:

    spec:
      serviceAccountName: airbyte-admin
      imagePullSecrets:
  - name: dockerhub
      nodeSelector:
        dedicated: root-node

After:

    spec:
      serviceAccountName: airbyte-admin
      imagePullSecrets:
        - name: dockerhub # <-- CHANGE HERE
      nodeSelector:
        dedicated: root-node

How

  • fix yaml indentation to allow correct parsing

Can this PR be safely reverted and rolled back?

  • [x] YES 💚

jakub-qg avatar Jul 12 '24 11:07 jakub-qg

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 12 '24 11:07 CLAassistant

Any update on when this can be fixed?

Udit107710 avatar Jul 29 '24 17:07 Udit107710