airbyte-platform icon indicating copy to clipboard operation
airbyte-platform copied to clipboard

Make NGNIX unprivileged docker images as default

Open nexcalmart opened this issue 1 year ago • 7 comments
trafficstars

What

To support non-root deployments on k8s NGINX has to be configured to work without root privileges. There is already an official docker image of NGINX in an unprivileged mode. Since the webapp doesn't need privileged access rights this has to be taken as the default docker image for the webapp.

How

Change the build configuration to switch to the non-privileged docker image if not explicitly overwritten by the env variable.

Recommended reading order

1-

Can this PR be safely reverted / rolled back?

  • [ X ] YES 💚
  • [ ] NO ❌

🚨 User Impact 🚨

No

nexcalmart avatar Nov 23 '23 14:11 nexcalmart

Your branch is not currently up-to-date with main. Please update your branch before attempting to snapshot your PR.

github-actions[bot] avatar Dec 01 '23 16:12 github-actions[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

sonarqubecloud[bot] avatar Dec 04 '23 06:12 sonarqubecloud[bot]

Your branch is not currently up-to-date with main. Please update your branch before attempting to snapshot your PR.

github-actions[bot] avatar Mar 04 '24 15:03 github-actions[bot]

@perangel This PR should be closed out by your work.

colesnodgrass avatar Mar 07 '24 22:03 colesnodgrass

Your branch is not currently up-to-date with main. Please update your branch before attempting to snapshot your PR.

github-actions[bot] avatar Mar 07 '24 22:03 github-actions[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
3.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Mar 08 '24 14:03 sonarqubecloud[bot]

Your branch is not currently up-to-date with main. Please update your branch before attempting to snapshot your PR.

github-actions[bot] avatar Mar 08 '24 14:03 github-actions[bot]